-
Notifications
You must be signed in to change notification settings - Fork 22
Do not raise an exception when a nested field is overridden by an env… #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clairbee
wants to merge
1
commit into
alexferl:master
Choose a base branch
from
clairbee:hotfix/nested-environment-overrides
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Do not raise an exception when a nested field is overridden by an env… #71
clairbee
wants to merge
1
commit into
alexferl:master
from
clairbee:hotfix/nested-environment-overrides
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ronment variable while reading another nested sibling Signed-off-by: Roman Kuzmenko <[email protected]>
4717e1f
to
e53ef21
Compare
clairbee
added a commit
to partcad/partcad
that referenced
this pull request
Mar 30, 2025
clairbee
added a commit
to partcad/partcad
that referenced
this pull request
Apr 1, 2025
clairbee
added a commit
to partcad/partcad
that referenced
this pull request
Apr 2, 2025
github-merge-queue bot
pushed a commit
to partcad/partcad
that referenced
this pull request
Apr 2, 2025
* Squashed all the telemetry commits * Addressed code review findings * Code review feedback fixes * Fixed merge conflict resolution regressions * Fixed merge conflict resolution regressions * Added documentation and attmpted to fix CI test failures * Minor refactoring and a workaround for a bug in vyper (alexferl/vyper#71) * Improved documentation of the default DSN as per code review recommendations * Disabled the logging integration in sentry * Fixed the sequence of initialization for logging and telemetry * Trying to fix deviations in the logging behavior between dev environment tests and the CI/CD pipeline * Reverting the behave test changes to the state prior to this feature branch even though it causes local failures * Minor fixes in the extension while testing this feature branch * Removed user_by from list all * More telemetry form the vscode extension
clairbee
added a commit
to partcad/partcad
that referenced
this pull request
Apr 2, 2025
github-merge-queue bot
pushed a commit
to partcad/partcad
that referenced
this pull request
Apr 3, 2025
* Set telemetry options with CLI * Updated the build process to reflect recent urgent file moves * Review findings, build failures, and tests * More workarounds for alexferl/vyper#71
github-merge-queue bot
pushed a commit
to partcad/partcad
that referenced
this pull request
Apr 3, 2025
* Set telemetry options with CLI * Updated the build process to reflect recent urgent file moves * Review findings, build failures, and tests * More workarounds for alexferl/vyper#71
github-merge-queue bot
pushed a commit
to partcad/partcad
that referenced
this pull request
Apr 3, 2025
* Set telemetry options with CLI * Updated the build process to reflect recent urgent file moves * Review findings, build failures, and tests * More workarounds for alexferl/vyper#71
github-merge-queue bot
pushed a commit
to partcad/partcad
that referenced
this pull request
Apr 3, 2025
* Set telemetry options with CLI * Updated the build process to reflect recent urgent file moves * Review findings, build failures, and tests * More workarounds for alexferl/vyper#71 * Slight improvement for code coverage
github-merge-queue bot
pushed a commit
to partcad/partcad
that referenced
this pull request
Apr 3, 2025
* Set telemetry options with CLI * Updated the build process to reflect recent urgent file moves * Review findings, build failures, and tests * More workarounds for alexferl/vyper#71 * Slight improvement for code coverage
clairbee
added a commit
to partcad/partcad
that referenced
this pull request
Apr 3, 2025
* Set telemetry options with CLI * Updated the build process to reflect recent urgent file moves * Review findings, build failures, and tests * More workarounds for alexferl/vyper#71 * Slight improvement for code coverage * Bumping aiohttp version to fix the build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ironment variable while reading another nested sibling