Skip to content

ADRV9001 new devices #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

ADRV9001 new devices #2764

wants to merge 16 commits into from
+8,641 −145

Conversation

nunojsa
Copy link
Collaborator

@nunojsa nunojsa commented Apr 14, 2025 •
edited
Loading

PR Description

This patchseries first fix some issues with ADRV9003 support where DPD is not available. Then, we do some rearrangements (most noticeable, dedicated compatibles for the new chips) and then we proceed to support ADRV9004, ADRV9005 and ADRV9006.

Also to note that these new devices do not have warmboot enabled by default. The only reason for that is because of the associated burden when updating to new APIs (as this coefficients would have to be updated for both CMOS and LVDS). In theory, and for consistency, ADRV9003 should also not have it but now that it has, let's keep them.

Fow now, only DTs for zcu102 but support for ZED and zc706 will come fairly soon after this is merged.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

nunojsa added 16 commits April 14, 2025 16:21
@nunojsa
iio: adc: adrv9002: fix adrv9003 not having dpd
5b07c6a 
ADRV9003 devices do not support digital predistortion. Therefore let's
not allow to enable it.

Fixes: 0b4d96b ("iio: adc: adrv9002: support adrv9003")
Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
arm64: boot: xilinx: zynqmp-zcu102-rev10-adrv9003: don't enable DPD
6e14146 
ADRV9003 does not support Digital predistortion: Hence, fix the DT and
make sure we're not enabling it for TX1.

Fixes: caa39fb ("arch: arm64: dts: add adrv9003 devicetrees")
Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
iio: adc: adrv9002: get rid of chip info array
4e4e7e2 
Typically, the preferred way for chip info structures is to have a
variable per device as that is more readable and maintainable over time.
Note that we need to do a similar conversion in the connected axi-adc
converter.

Signed-off-by: Nuno Sa <[email protected]>
@nunojsa
iio: adc: adrv9002: allow a per chip 'struct axiadc_chip_info'
fd46a8d 
Instead of reporting everything as adrv9002, allow have different
struct axiadc_chip_info with the proper chip name. This will be more
important when supporting more chips of the adrv9001 family.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
iio: adc: cf_axi_adc_core: add a specific compatible for adrv9003
62ec408 
Add a dedicated compatible for the ADRV9003 device. After all it's a
different chip from ADRV9002.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
iio: adc: ad_adc: add a specific compatible for adrv9003
db48552 
Add a dedicated compatible for the ADRV9003 device. After all it's a
different chip from ADRV9002.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
iio: frequency: cf_axi_dds: add a specific compatible for adrv9003
14cb44e 
Add a dedicated compatible for the ADRV9003 device. After all it's a
different chip from ADRV9002.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
arm64: boot: xilinx: zynqmp-zcu102-rev10-adrv9003: use dedicated comp…
d18aded 
…atibles

Use a dedicated compatible for ADRV9003 devices. This will go inline
with new chips being supported in following changes.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
firmware: add new profiles for the new supported devices
d208e76 
Add LVDS and CMOS profiles for ADRV9004, ADRV9005 and ADRV9006.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
iio: adc: adrv9002: drop useless parent assignment.
ef12a18 
There's no need to the IIO parent device as that is already done by the
core when allocating the device.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
iio: adc: adrv9002: add support for new devices.
43c1cc3 
Add support for the ADRV9004, ADRV9005 and ADRV9006 Narrow-Band
and Wideband RF Transceivers.

They are similar to ADRV9002 wirh some key differences:

ADRV9004:
 * No DPD support;

ADRV9005:
 * Only 1R1T and no TX tracking calibrations for FDD profiles.

ADRV9006:
 * No DPD support;
 * No external LO support;
 * No High performance ADCs;
 * Only FH normal mode for PLL locking.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
iio: adc: ad:adc: add support for new devices
c1b6deb 
Add new compatibles for ADRV9004 and ADRV9006 which also have two RX
ports and thus make use of this driver.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
iio: adc: cf_axi_adc_core: add support for new devices
d6fcdf4 
Add new compatibles for ADRV9004, ADRV9005 and ADRV9006. These are new
devices being supported in the ADRV9002 family.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
iio: dac: cf_axi_dds: add support for new devices
3332ab6 
Add new compatibles for ADRV9004, ADRV9005 and ADRV9006. These are new
devices being supported in the ADRV9002 family.

Note that rx2tx2 variants are also being added for devices that support
it. ADRV9005 does not have since it only has TX port.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
arm64: configs: adi_zynqmp_defconfig: add new ADRV900x profiles
24fa9c8 
Add profiles for the new devices supported byu the ADRV9002 driver.

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
arm64: dts: xilinx: support new ADRV900x variants
c6ce2d4 
Add devicetrees to support ADRV9004, ADRV9005 and ADRV9006 (and the rx2tx2
variants where it makes sense).

Signed-off-by: Nuno Sá <[email protected]>
@nunojsa nunojsa force-pushed the staging/adrv9002-new-devs branch from ae510f2 to c6ce2d4 Compare April 14, 2025 15:22
@nunojsa
Copy link
Collaborator Author

nunojsa commented Apr 14, 2025

v2:

  • Fix adrv9005 chip info not having has_dpd = true;
  • Don't treat having the DPD property (on devices that do not support it) as an error. Mostly for backward compatibility reasons as lot's of adrv9003 users might not care about dpd but still use (or copied) our DTs and so, using newer kernels would mean fail to probe adrv9003. As that is far from ideal, just ignore the property and log a warning;
  • Update adrv9005 CMOS default profile to use 4.5MHz BW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@btogorean btogorean Awaiting requested review from btogorean btogorean is a code owner

@chegbeli chegbeli Awaiting requested review from chegbeli chegbeli is a code owner

@buha buha Awaiting requested review from buha buha is a code owner

@amiclaus amiclaus Awaiting requested review from amiclaus amiclaus is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

@CiprianRegus CiprianRegus Awaiting requested review from CiprianRegus CiprianRegus is a code owner

@machschmitt machschmitt Awaiting requested review from machschmitt machschmitt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nunojsa