Use SKIE Observing to collect state flows in SwiftUI #54
Conversation
This commit updates the `ContentView` to use `Observing` from the SKIE library to collect the `StateFlow` exposed by the `MainViewModel` into SwiftUI. - This replaces the `.collect` method, which is no longer needed when using `Observing`. - Adds a comment to reference the SKIE documentation for flows in SwiftUI.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @cartland, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the ContentView and CartView to use Observing from the SKIE library for collecting StateFlow exposed by the MainViewModel in SwiftUI. This replaces the .collect method, which is no longer needed when using Observing. A comment referencing the SKIE documentation for flows in SwiftUI has been added.
Highlights
- SKIE Observing: The pull request leverages SKIE's
Observingfunctionality to handle state flow collection in SwiftUI, simplifying the code and removing the need for the.collectmethod. - Code Simplification: The changes streamline the way
homeUiStateandcartUiStateare observed and updated in the UI, leading to cleaner and more concise code. - Documentation Reference: A comment has been added to both
CartViewandContentViewto reference the SKIE documentation for flows in SwiftUI, providing a helpful resource for understanding the implementation.
Changelog
- Fruitties/iosApp/iosApp/CartView.swift
- Added a comment referencing the SKIE documentation for flows in SwiftUI on line 58.
- Fruitties/iosApp/iosApp/ContentView.swift
- Removed the
@State var homeUIStatedeclaration on lines 27-28. - Replaced the
.collectmethod withObservingto collect thehomeUiStateon line 28. - Added a comment referencing the SKIE documentation for flows in SwiftUI on line 27.
- Removed the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A flow of state,
Observed with SKIE's grace,
SwiftUI's delight.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the ContentView and CartView to use Observing from the SKIE library for collecting StateFlow exposed by MainViewModel in SwiftUI. The .collect method is removed, and a comment referencing the SKIE documentation is added. Overall, the changes seem reasonable and improve the way state flows are handled in SwiftUI.
Merge Readiness
The code changes look good and the pull request is ready to be merged. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
|
|
||
| // The ViewModel exposes a StateFlow. |
There was a problem hiding this comment.
It would be helpful to add a comment explaining why the @State property homeUIState was removed. This provides context for the change and clarifies the motivation behind using Observing instead.
|
@bentrengrove this is similar to the changes in #37 but also makes the changes in ContentView. |
This commit updates the
ContentViewto useObservingfrom the SKIE library to collect theStateFlowexposed by theMainViewModelinto SwiftUI..collectmethod, which is no longer needed when usingObserving.