Skip to content

Add reporter exceptions to test exception as suppressed instead of swallowing them #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add reporter exceptions to test exception as suppressed instead of swallowing them #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions module/geb-spock/src/main/groovy/geb/spock/OnFailureReporter.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ class OnFailureReporter implements IMethodInterceptor {
if (spec.testManager.reportingEnabled) {
try {
spec.testManager.reportFailure()
} catch (Exception ignored) {
// ignore
} catch (Exception reportingException) {
throwable.addSuppressed(reportingException)
}
}
throw throwable
Expand Down
5 changes: 3 additions & 2 deletions module/geb-spock/src/test/groovy/geb/spock/GebReportingSpecSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ class GebReportingSpecSpec extends Specification {
given:
config.reporter = new Reporter() {
void writeReport(ReportState reportState) {
throw new Exception()
throw new Exception("Foo")
}

void addListener(ReportingListener listener) {
Expand All @@ -204,7 +204,8 @@ class GebReportingSpecSpec extends Specification {
"""

then:
result.failures.first().exception in ConditionNotSatisfiedError
result.failures.first().exception instanceof ConditionNotSatisfiedError
result.failures.first().exception.suppressed*.message == ['Foo']
}

def "report called from fixture method should create report with default name"() {
Expand Down