Fix issue3296: prevent writing when running tests in CDMS

[keflavich]

Simple fix for #3296. We do want the remote tests grabbing stuff from the remote server, but you're right, we don't want it modifying data files in the repository.

[bsipocz]

Actually, as this is a new kwarg, it will need a changelog entry.
And maybe consider being a bit more verbose with naming the kwarg, but it's not a blocker.

[bsipocz]

A more verbose arg would be nice, maybe call this write_cached or refresh_cashed?

[keflavich]

I'll be more verbose, but I think a different keyword is warranted... write_new_cache, probably.

[bsipocz]

Sure. Anything more that just write is an improvement, and write_new_cache is quite good. Though maybe it will need a switch in logic, e.g. if it's set then ignore whatever is in use_cache rather than the other way around.

[bsipocz]

Weird that the CI wasn't kicking in, I'm fairly certain one of the lines is too long. I also now see uncatched warnings, please address those and then we can merge this.

[bsipocz]

This now issues a couple of warnings in the tests that we need to handle.

[keflavich]

Uhoh.... that shouldn't be happening.

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.47%. Comparing base (4ed16e4) to head (213a0cd).
Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
astroquery/linelists/cdms/core.py	25.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3297      +/-   ##
==========================================
+ Coverage   69.36%   69.47%   +0.10%     
==========================================
  Files         232      232              
  Lines       19692    19707      +15     
==========================================
+ Hits        13659    13691      +32     
+ Misses       6033     6016      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bsipocz]

You're living in the future :) (But I'll fix it at release time :) )

[keflavich]

oh shoot, I had fixed it and just didn't push yet... I got some failing tests still to fix

[bsipocz]

I did run the tests prior merging and it was all clear (besides a ConnectionError, but I double checked and that one was present on main, too.

[keflavich]

I think I needed to update my local table....

Anyway, I have a fix to push because this last test took too long to run for my liking

[bsipocz]

I would say don't stress on the retrieval one as we don't run it often and it's only 2s on my local. But if you would fix the really long running (400+s )and then failing one, the test_regression_allcats, that would be great.

[bsipocz]

Thanks!

[keflavich]

There might be a related failing test - I'm not sure yet. I got this error, but it coincided with a server error:

___________________________________________________________________________________________________________ test_regression_allcats ____________________________________________________________________________________________________________

    @pytest.mark.bigdata
    @pytest.mark.remote_data
    def test_regression_allcats():
        """
        Expensive test - try all the molecules
        """
        species_table = CDMS.get_species_table(write_new_species_cache=False)
        for row in species_table:
            tag = f"{row['tag']:06d}"
>           result = CDMS.get_molecule(tag)

astroquery/linelists/cdms/tests/test_cdms_remote.py:133:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
astroquery/linelists/cdms/core.py:399: in get_molecule
    result = self._parse_cat(response)
astroquery/linelists/cdms/core.py:469: in _parse_cat
    intcol = np.array(list(map(parse_letternumber, result[key])),
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

st = '13-'

    def parse_letternumber(st):
        """
        Parse CDMS's two-letter QNs

        From the CDMS docs:
        "Exactly two characters are available for each quantum number. Therefore, half
        integer quanta are rounded up ! In addition, capital letters are used to
        indicate quantum numbers larger than 99. E. g. A0 is 100, Z9 is 359. Small
        types are used to signal corresponding negative quantum numbers."
        """
        asc = string.ascii_lowercase
        ASC = string.ascii_uppercase
        newst = ''.join(['-' + str(asc.index(x)+10) if x in asc else
                         str(ASC.index(x)+10) if x in ASC else
                         x for x in st])
>       return int(newst)
E       ValueError: invalid literal for int() with base 10: '13-'

astroquery/linelists/cdms/core.py:497: ValueError

I'm re-running.