-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(synthetics): syn-nodejs-puppeteer-10.0 as supported runtime #34241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(synthetics): syn-nodejs-puppeteer-10.0 as supported runtime #34241
Conversation
…#34240) Closes aws#34240. [Runtime versions using Node.js and Puppeteer](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html) confirms that Synthetics runtime `syn-nodejs-puppeteer-10.0` is available. Added `syn-nodejs-puppeteer-10.0` as supported runtime. N/A - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ejs-puppeteer-10.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution.
I've added one comment.
* New Features: | ||
* - **Bug fixes** Bug fix related to date ranges and pending requests in HAR files. | ||
* | ||
* @see https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment appears to be referring to the 9.1 bug fix:
Changes in syn-nodejs-puppeteer-9.1 – Bug fixes related to date ranges and pending requests in HAR files are fixed.
The correct bug fix for 10.0 is:
Changes in syn-nodejs-puppeteer-10.0 – The bug related to closing the browser that took excessively long is fixed.
Also could you add an integ test for 10.0? aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary.ts Line 104 in 15791d7
|
Issue # (if applicable)
Closes #34240.
Reason for this change
Runtime versions using Node.js and Puppeteer confirms that Synthetics runtime
syn-nodejs-puppeteer-10.0
is available.Description of changes
Added
syn-nodejs-puppeteer-10.0
as supported runtime.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Current tests are sufficient for the new version.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license