-
Notifications
You must be signed in to change notification settings - Fork 301
Add boots/smee container logs to support bundle #9683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9683 +/- ##
==========================================
+ Coverage 69.76% 69.78% +0.02%
==========================================
Files 672 672
Lines 49616 49679 +63
==========================================
+ Hits 34615 34669 +54
- Misses 13224 13230 +6
- Partials 1777 1780 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cd38606
to
806bac7
Compare
pkg/diagnostics/diagnostic_bundle.go
Outdated
if e.hostBundle == nil { | ||
return false | ||
} | ||
return !reflect.DeepEqual(e.hostBundle.Spec, supportBundleSpec{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The supportBundleSpec
struct also has Analyzers
field, what if the collector is not present but Analyzer is present? In this case it will still return True.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. Right now there are no analyzers that will get added to this hostBundle, but I suppose it could in the future. I'll find a better check here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made a change that makes it a lot more clear
806bac7
to
8c46f42
Compare
Issue #, if available:
#4179
Description of changes:
Smee logs now accessible in support-bundle
The following gets added to support bundle yaml following troubleshoot docs here
Creates a new nested directory at
host-collectors/run-host
Smee logs located here
Example content
boots-logs.txt
boots-logs-info.json