Treat download error during input prefetching as lost input. #25929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Remote-Exec
... so that bazel can correctly rewind the build.
coeuvre
force-pushed
the
push-qykxrosxyxut
branch
from
580e673 to
e06dd19
Compare
fmeum
approved these changes
Apr 23, 2025
fmeum
reviewed
Apr 23, 2025
| @@ -569,26 +570,33 @@ private Completable downloadFileNoCheckRx( | |||
| } | |||
|
|
|||
| Path finalPath = path; | |||
| PathFragment execPath = finalPath.relativeTo(execRoot); | |||
There was a problem hiding this comment.
Does this handle symlinks correctly? We need the path of the artifact, not the download exec path.
There was a problem hiding this comment.
Symlink is handled by the call site as the form of downloadFileNoCheckRx().onErrorResumeNext(...).
fmeum
approved these changes
Apr 23, 2025
github-actions
bot
removed
the
awaiting-review
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Apr 24, 2025
... so that bazel can correctly rewind the build. Fixes bazelbuild#25860. Closes bazelbuild#25929. PiperOrigin-RevId: 750917248 Change-Id: I8a278a36bb6565e1d7204eb1a0d8a800abd845bd
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 25, 2025
…25942) ... so that bazel can correctly rewind the build. Fixes #25860. Closes #25929. PiperOrigin-RevId: 750917248 Change-Id: I8a278a36bb6565e1d7204eb1a0d8a800abd845bd Commit ba6f6f7 Co-authored-by: Chi Wang <[email protected]>
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Apr 25, 2025
... so that bazel can correctly rewind the build. Fixes bazelbuild#25860. Closes bazelbuild#25929. PiperOrigin-RevId: 750917248 Change-Id: I8a278a36bb6565e1d7204eb1a0d8a800abd845bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that bazel can correctly rewind the build.
Fixes #25860.