[PM-19108] Add privileged app management screen #4862
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## innovation-sprint/privileged-apps/trust-dialog #4862 +/- ##
==================================================================================
- Coverage 83.62% 83.05% -0.57%
==================================================================================
Files 623 628 +5
Lines 48491 48904 +413
Branches 6722 6758 +36
==================================================================================
+ Hits 40551 40619 +68
- Misses 5668 6011 +343
- Partials 2272 2274 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job, no security vulnerabilities found in this Pull Request |
SaintPatrck
force-pushed
the
innovation-sprint/privileged-apps/settings-mgmt
branch
from
e26c43a to
15ae542
Compare
| } | ||
|
|
||
| item { | ||
| Spacer(modifier = Modifier.height(88.dp)) |
There was a problem hiding this comment.
We usually reserve the 88.dp for screens that have a FAB and 16.dp for the rest of them
| } | ||
|
|
||
| @Composable | ||
| private fun LazyItemScope.PrivilegedAppHeaderItem( |
There was a problem hiding this comment.
A LazyItemScope should not be composable?
| if (canDelete) { | ||
| BitwardenStandardIconButton( | ||
| vectorIconRes = R.drawable.ic_send_pending_delete, | ||
| contentDescription = "", |
There was a problem hiding this comment.
This should have a contentDescription
| cardStyle: CardStyle, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| Row( |
There was a problem hiding this comment.
We should already have standard components for this sort of thing already
|
|
||
| @Preview | ||
| @Composable | ||
| private fun PrivilegedAppsListScreenPreview() { |
There was a problem hiding this comment.
Can we call this function PrivilegedAppsListScreen_preview
| Spacer(modifier = Modifier.height(8.dp)) | ||
| } | ||
| itemsIndexed( | ||
| key = { _, item -> "communityTrust_${item.packageName}_${item.signature}" }, |
| cardStyle = state.communityTrustedApps | ||
| .toListItemCardStyle(index = index), | ||
| modifier = Modifier | ||
| .padding(horizontal = 16.dp) |
There was a problem hiding this comment.
Can we use the standardHorizontalMargin() function here
| modifier = Modifier | ||
| .padding(horizontal = 16.dp) | ||
| .fillMaxWidth() | ||
| .animateItem(), |
| data class Fido2TrustState( | ||
| val googleTrustedApps: ImmutableList<PrivilegedAppListItem>, | ||
| val communityTrustedApps: ImmutableList<PrivilegedAppListItem>, | ||
| val userTrustedApps: ImmutableList<PrivilegedAppListItem>, |
There was a problem hiding this comment.
I love that we can put ImmutableLists directly into parcelable classes now 👨🍳
| } | ||
|
|
||
| override suspend fun getCommunityTrustedPrivilegedAppsOrNull(): PrivilegedAppAllowListJson? { | ||
| return withContext(ioScope.coroutineContext) { |
There was a problem hiding this comment.
Do we need this specifically for the json .decodeFromStringOrNull part?
SaintPatrck
force-pushed
the
innovation-sprint/privileged-apps/trust-dialog
branch
from
465c5ce to
9beb3ec
Compare
Allow users to manage trusted privileged applications and view privileged applications that are trusted by external sources.
…ps list - Added a new vector graphic file `ic_delete.xml` for the delete icon. - Updated the delete button icon in the `PrivilegedAppsListScreen` from `ic_send_pending_delete` to `ic_delete`.
- Removed unused string resources: `trusted_by_google_x`, `trusted_by_you_x`, and `trusted_by_the_community_c`.
SaintPatrck
force-pushed
the
innovation-sprint/privileged-apps/settings-mgmt
branch
from
208e972 to
3c1ef13
Compare
🎟️ Tracking
PM-19108
📔 Objective
Allow users to manage trusted privileged applications and view
privileged applications that are trusted by external sources.
📸 Screenshots
Screen_recording_20250313_161906.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes