Skip to content

PM-20400: Display snackbar confirming log deletion #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Apr 23, 2025

🎟️ Tracking

PM-20400

📔 Objective

This PR adds a confirmation Snackbar after deleting flight recorder logs.

📸 Screenshots

Single Log Deleted All Logs Deleted

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront requested review from brian-livefront and a team as code owners April 23, 2025 14:58
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc4845693-0c24-403d-a920-99ab84180d3d

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.86%. Comparing base (39b88d6) to head (587daed).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ightrecorder/recordedLogs/RecordedLogsViewModel.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5088      +/-   ##
==========================================
+ Coverage   83.55%   83.86%   +0.31%     
==========================================
  Files         623      595      -28     
  Lines       49671    48847     -824     
  Branches     6734     6711      -23     
==========================================
- Hits        41501    40966     -535     
+ Misses       5890     5613     -277     
+ Partials     2280     2268      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit 37a0d19 Apr 23, 2025
9 checks passed
@david-livefront david-livefront deleted the PM-20400-delete-logs-snackbar branch April 23, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants