-
Notifications
You must be signed in to change notification settings - Fork 190
fix(next): next_entity_type_config dependencies #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mglaman
wants to merge
7
commits into
chapter-three:main
Choose a base branch
from
mglaman:NextEntityTypeConfig-config-dependencies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d550902
fix(next): next_entity_type_config dependencies
mglaman 1564a59
Merge branch 'main' into NextEntityTypeConfig-config-dependencies
mglaman ac08601
Merge branch 'main' into NextEntityTypeConfig-config-dependencies
mglaman 837a9c9
Merge branch 'main' into NextEntityTypeConfig-config-dependencies
mglaman 9a9258e
fix(next): next_entity_type_config dependencies
mglaman 6567efe
Merge branch 'main' into NextEntityTypeConfig-config-dependencies
mglaman 40e285e
fix(next): next_entity_type_config dependencies
mglaman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I misreading this assertion?
If the purpose of
calculateDependencies()
is to add the proper dependencies to the config, why is the test asserting thatgetDependencies()
is an empty array? How does this test that dependencies are added properly?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I can't remember if I left this here to show the test was still failing or what... Or if I wrote the test first and then the fix?
I'll follow back up on this today