generated from cisagov/ScubaGear
-
Notifications
You must be signed in to change notification settings - Fork 3
Draft: Use Managed Identity for Getting Application Certificate in Container #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jacdavi
wants to merge
14
commits into
main
Choose a base branch
from
managed_identity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try new method for logging azcopy errors
FYI @MichaelHicks-MSFT and @eagbaya Everything should be good to go, though I'd like to test in GCC High and confirm Microsoft's update has rolled out to all regions before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
This issue or pull request is awaiting the outcome of another issue or pull request
gearconnect
Relates to GearConnect (m365)
improvement
This issue or pull request will add new or improve existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Based on new features from Microsoft, this changes how we get the application's certificate inside the container.
With this change, we now use a User-Managed Identity to access key vault instead of passing the certificate as a secure environment variable.
This was previously unsupported when deploying in a vnet.
This also removes a configuration option for certificate expiration.
We no longer need to rotate frequently since the certificate remains in key vault, so the expiration is fixed at 1 year.
This also updates our terraform providers to the latest versions (needed for identities to work).
💭 Motivation and context
Previously we were passing the application certificate as a secure environment variable to the container.
This was not ideal, and had increased the risk of the certificate being leaked.
Since Microsoft has now added supported for using a Managed Identity inside an Azure Container Instance behind a vnet, this PR switches to using that for key vault access.
🧪 Testing
Tested in
westus2
with and without a vnet and verified certificate installed in the containerDraft
This is currently a draft as we wait for Microsoft to fully roll out the update to all US commercial and GCC high regions