WIP: streamline mill.api.Ctx usage #4794
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, we want use
mill.api.Ctx
instead of e.g.mill.api.Ctx.Log
ormill.api.Ctx.Job
when passing it implicitly to helper methods and workers. We typically need the other properties too when evolving the implementations or providing a second implementation. If we usemill.api.Ctx
from the start, we can maintain a more applicable and stable API.