Skip to content

improve button #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Apr 8, 2025
Merged

improve button #83

merged 35 commits into from
Apr 8, 2025

Conversation

VislovIvan
Copy link
Collaborator

  • added new parameters (loading and image)

mikhailChelbaev
mikhailChelbaev requested changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@mikhailChelbaev mikhailChelbaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it works well, but there are few bugs, and the code needs some improvements.

Examples/DemosApp/DemosApp/ComponentsPreview/PreviewPages/ButtonPreview.swift Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why you included all the if conditions, but I think it's better to remove them. This way, people can understand how the parameters interact with each other.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also sort the params in alphabetical order

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add contentSpacing param and a toggle to show / hide the title (similar to the one in alert / modals)

mikhailChelbaev
mikhailChelbaev requested changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@mikhailChelbaev mikhailChelbaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also a bug: tint color is not applied to local image

mikhailChelbaev
mikhailChelbaev requested changes Apr 8, 2025
View reviewed changes
@VislovIvan
fix preview sort
5cfdf75
@VislovIvan
code fix
f3a2ee2 
- delete unused code
- code style fix
- documentation fix
- fix extension accessibility
@VislovIvan
fix image size updating
073f1ef
@VislovIvan
some fix stackView
9243dcd
@VislovIvan
tint color fix
ae6e9c5
@VislovIvan
fix imageView location bug
3ff5b27 
- the image view added based on the imagePosition value in the model
@mikhailChelbaev mikhailChelbaev merged commit 183b632 into dev Apr 8, 2025
1 check passed
@mikhailChelbaev mikhailChelbaev deleted the improve-button branch April 8, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhailChelbaev mikhailChelbaev mikhailChelbaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VislovIvan @mikhailChelbaev