-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat(direction): add direction option #2243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for implementing this feature. However, there still seems to be quite a bit of work to do to complete it:
- The elements in the sidebar do not have consistent right margins, and the spacing of the social icons at the bottom is uneven.
- The positions of the breadcrumb and search input box in the top bar are reversed.
- The metadata in the homepage article list does not follow the right-to-left order.

- The dates on the archive page are stacked together, and the vertical line of the timeline is also separated from the entries on the left and right.

Hi @cotes2020, I've fixed the issues you pointed out. Please take a look when you have time. Thanks! |
If you don't mind, please upload the modified rendering result image so that we can review it more quickly. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it's an improvement over the first version, the Recent Updated and Trending Tags are still noticeably to the right, as you may have noticed.
Also, you've added a lot of invalid commits to this PR, please remove them, thanks.
Type of change
Description
This pull request introduces support for right-to-left (RTL) language direction in the Jekyll Chirpy theme. The changes include:
The default direction is set to ltr if the direction option is not specified in _config.yml.
Additional context
This addiction does not introduce any breaking changes and is fully compatible with existing functionality. The direction can set by setting the direction parameter in the site configuration.