Skip to content

Introduced a sql.LiteralExpression, and used it in most places #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Introduced a sql.LiteralExpression, and used it in most places #2946

wants to merge 2 commits into from

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Apr 17, 2025

This is to support greater plan builder / analyzer compatibility with Doltgres, which has its own Literal implementation.

@zachmu zachmu mentioned this pull request Apr 17, 2025
Open
@zachmu zachmu requested a review from max-hoffman April 17, 2025 23:57
max-hoffman
max-hoffman approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk why a literal would be more complicated than value and type, but otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @max-hoffman