-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Re-enable C++/CLI tests #11008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Or overriding the implicit versions during the test themselves |
Why not use |
C++/CLI project system does not support PackageDownload. And PackageDownload uses nuget |
Fixed using the new package reference support! |
There are 3 tests, It_can_generate_correct_depsJson_file, It_can_generate_all_runtimeconfig_files_to_output_folder, It_can_generate_all_depsjson_files_to_output_folder, that were all skipped for the predecessor to this issue. When running those tests, they all fail for the same reason:
(The text in the AzDO logs got cut off there, but you get the gist.) I'm reopening this issue and marking those tests as skipped by this issue. |
@v-wuzhai can you take a look in your current pass over broken and skipped tests? I think we should be able to enable packagereference like the other c++ CLI tests and it'll download the apphost it needs. |
I will try to enable EnableManagedPackageReferenceSupport to address the pass over broken and skipped tests. |
C++ does not support package restore. So, it is cannot download apphost pack from the internet. Since I made a change recently to use stage 2 bundled version props file instead of stage 0 (to avoid needing to update stage 0 when runtime insert), apphost will not be in the "dotnet" folder. The solution could be, in the test set up, download the missing apphost pack. But that will duplicate a lot of dotnet/installer code. Or move these tests to dotnet/installer.
The text was updated successfully, but these errors were encountered: