Skip to content

Re-enable C++/CLI tests #48511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

Re-enable C++/CLI tests #48511

merged 4 commits into from
Apr 22, 2025
+33 −30

Conversation

v-wuzhai
Copy link
Member

@v-wuzhai v-wuzhai commented Apr 16, 2025 •
edited
Loading

Fixed #11008

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Apr 16, 2025
@v-wuzhai v-wuzhai force-pushed the dev/Jason/ReenableTests branch from 352764f to b2030b9 Compare April 16, 2025 08:38
@v-wuzhai v-wuzhai force-pushed the dev/Jason/ReenableTests branch from b2030b9 to 12ded62 Compare April 16, 2025 08:57
@v-wuzhai v-wuzhai marked this pull request as ready for review April 17, 2025 07:47
@v-wuzhai v-wuzhai requested review from Copilot and marcpopMSFT April 17, 2025 07:47
Copilot
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables previously disabled C++/CLI tests by removing the Skip parameters from several test attributes.

  • Removed Skip attribute from tests verifying depsJson, runtimeconfig, and depsjson file generation.
Files not reviewed (3)
  • test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTest/NETCoreCppCliTest.vcxproj: Language not supported
  • test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestB/NETCoreCppCliTestB.vcxproj: Language not supported
  • test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestC/NETCoreCppCliTestC.vcxproj: Language not supported

@marcpopMSFT marcpopMSFT merged commit a8d3bb6 into main Apr 22, 2025
39 checks passed
@marcpopMSFT marcpopMSFT deleted the dev/Jason/ReenableTests branch April 22, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@marcpopMSFT marcpopMSFT marcpopMSFT approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable C++/CLI tests
2 participants
@v-wuzhai @marcpopMSFT