Skip to content

Re-enable C++/CLI tests #11008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wli3 opened this issue Mar 26, 2020 · 7 comments · May be fixed by #48511
Open

Re-enable C++/CLI tests #11008

wli3 opened this issue Mar 26, 2020 · 7 comments · May be fixed by #48511
Assignees
@marcpopMSFT
Milestone
7.0.2xx

Comments

@wli3
Copy link

wli3 commented Mar 26, 2020 •
edited
Loading

C++ does not support package restore. So, it is cannot download apphost pack from the internet. Since I made a change recently to use stage 2 bundled version props file instead of stage 0 (to avoid needing to update stage 0 when runtime insert), apphost will not be in the "dotnet" folder. The solution could be, in the test set up, download the missing apphost pack. But that will duplicate a lot of dotnet/installer code. Or move these tests to dotnet/installer.
@wli3 wli3 self-assigned this Mar 26, 2020
@wli3 wli3 added this to the 5.0.1xx milestone Mar 26, 2020
@marcpopMSFT marcpopMSFT added the untriaged Request triage from a team member label Apr 16, 2020
@wli3 wli3 removed the untriaged Request triage from a team member label Apr 20, 2020
@wli3 wli3 mentioned this issue Sep 21, 2020
Merged
@wli3 wli3 mentioned this issue Oct 14, 2020
Merged
@marcpopMSFT marcpopMSFT modified the milestones: 5.0.1xx, 7.0.1xx Aug 26, 2021
@wli3
Copy link
Author

wli3 commented Sep 29, 2021

Or overriding the implicit versions during the test themselves

@wli3 wli3 assigned dsplaisted and unassigned wli3 Sep 29, 2021
@wli3 wli3 mentioned this issue Sep 29, 2021
Closed
3 tasks
@Nirmal4G
Copy link
Contributor

Why not use PackageDownload?

@wli3
Copy link
Author

wli3 commented Sep 29, 2021

C++/CLI project system does not support PackageDownload. And PackageDownload uses nuget

@dsplaisted dsplaisted mentioned this issue Oct 12, 2021
Closed
@elinor-fung elinor-fung mentioned this issue Nov 8, 2022
Merged
@dsplaisted dsplaisted mentioned this issue Nov 8, 2022
Merged
@marcpopMSFT marcpopMSFT modified the milestones: 7.0.1xx, 7.0.2xx Nov 16, 2022
@marcpopMSFT
Copy link
Member

Fixed using the new package reference support!

@MiYanni
Copy link
Member

MiYanni commented Jun 21, 2024

There are 3 tests, It_can_generate_correct_depsJson_file, It_can_generate_all_runtimeconfig_files_to_output_folder, It_can_generate_all_depsjson_files_to_output_folder, that were all skipped for the predecessor to this issue. When running those tests, they all fail for the same reason:

C:\h\w\BA370A1F\p\d\sdk\9.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(157,5): error NETSDK1145: The Apphost pack is not installed and NuGet package restore is not supported. Upgrade Visual Studio, remove global.json if it specifies a certain SDK version, and uninstall the newer SDK. For more options visit   https://aka.ms/targeting-apphost-pack-missing  Pack Type:Apphost, Pack directory: C:\h\w\BA370A1F\p\d\packs\Micros

(The text in the AzDO logs got cut off there, but you get the gist.) I'm reopening this issue and marking those tests as skipped by this issue.

@MiYanni MiYanni reopened this Jun 21, 2024
@MiYanni MiYanni mentioned this issue Jun 21, 2024
Merged
@marcpopMSFT
Copy link
Member

@v-wuzhai can you take a look in your current pass over broken and skipped tests? I think we should be able to enable packagereference like the other c++ CLI tests and it'll download the apphost it needs.

@v-wuzhai
Copy link
Member

@v-wuzhai can you take a look in your current pass over broken and skipped tests? I think we should be able to enable packagereference like the other c++ CLI tests and it'll download the apphost it needs.

I will try to enable EnableManagedPackageReferenceSupport to address the pass over broken and skipped tests.

@v-wuzhai v-wuzhai linked a pull request Apr 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcpopMSFT marcpopMSFT

Labels
None yet
Projects
None yet
Milestone
7.0.2xx
Development

Successfully merging a pull request may close this issue.

Re-enable C++/CLI tests dotnet/sdk
6 participants
@dsplaisted @Nirmal4G @wli3 @marcpopMSFT @MiYanni @v-wuzhai