Skip to content

Fixes RepositoryUrl attribute generation #48582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes RepositoryUrl attribute generation #48582

wants to merge 1 commit into from
+1 −1

Conversation

tmat
Copy link
Member

@tmat tmat commented Apr 18, 2025

Fixes #48580

@Copilot Copilot AI review requested due to automatic review settings April 18, 2025 19:00
Copilot
Copilot AI reviewed Apr 18, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.GenerateAssemblyInfo.targets: Language not supported

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Apr 18, 2025
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@tmat
Copy link
Member Author

tmat commented Apr 18, 2025 •
edited
Loading

@baronfel PTAL. Will also port to 9.0.3xx

@tmat tmat enabled auto-merge (squash) April 22, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@baronfel baronfel baronfel approved these changes

Assignees
No one assigned
Labels
untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting IncludeSourceRevisionInInformationalVersion may cause RepositoryUrl assembly attribute to be empty
2 participants
@tmat @baronfel