Update Model JSON Validation to Pydantic V2 Style #1515
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @akaashdash! Thanks for opening a PR, good catch. Unfortunately we are about to merge the v1.0 branch into main, so I would rather not merge this PR as it would lead to merge conflicts down the road. Instead I've applied the change you've proposed to v1.0 in a different PR #1539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when parsing JSON responses from LLMs into the Pydantic BaseModel,
parse_rawis being used. This is deprecated behavior as of Pydantic v2 and is slated to be removed in the future. The new behavior is to usemodel_validate_jsonwhich behaves the same way.No warnings are observed as all migration warnings are suppressed.
It is best to migrate now before this causes issues. Outlines already depends on Pydantic v2 so there is no need to support any behavior from Pydantic v1.