-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Drush commands for workspaces - #5933 #5934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 13.x
Are you sure you want to change the base?
Conversation
return; | ||
} | ||
|
||
$workspace->publish(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fails with wse enabled, because \Drupal\wse_preview\Negotiator\CookieWorkspaceNegotiator::unsetActiveWorkspace
tries to get the user session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into this asap :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been resolved in wse?
This needs Drush test coverage. I think an integration test will fit well. As setup the command would create a workspace, make it active, create a node in the workspace, run the drush command, and ensure the node is now published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we add an interact() method that lets you pick a workspace from a select if the argument is not provided. I guess show the 20 most recently active workspaces.
We can skip the interact() method for now. I stubbed out a test but it needs more work and I cant work on this anymore. Hopefully someone else can. |
Aims to fix #5933