Small Python test improvements #727
Conversation
Y--
force-pushed
the
yl/small-test-improvements
branch
from
289218c to
6badce7
Compare
test/pycheck/utils.py
Outdated
| yield | ||
| self.sql("RESET log_min_messages") |
There was a problem hiding this comment.
I think it would be good to clean up using a finally.
(don't apply suggestion verbatim it mixes tabs and spaces it seems)
| yield | |
| self.sql("RESET log_min_messages") | |
| try: | |
| yield | |
| finally: | |
| self.sql("RESET log_min_messages") |
test/pycheck/utils.py
Outdated
| buffer = io.StringIO() | ||
| with redirect_stdout(buffer): |
test/pycheck/utils.py
Outdated
| self.wait_until( | ||
| lambda: self.try_sql( |
There was a problem hiding this comment.
nit: Instead of waiting for a predicate, how about we wait until no exception occurs. Then we can make this a context manager, instead of having to use lambdas. (in case you haven't noticed. I much prefer context managers over lambdas in python)
There was a problem hiding this comment.
Feel free to merge without changing this. I can create a follow up PR to make this a bit nicer.
test/pycheck/utils.py
Outdated
| ), | ||
| dbname=dbname, | ||
| ) | ||
| with self.silent_logs(): |
There was a problem hiding this comment.
What errors/warnings is this silencing? Would be good to add a comment, because I wouldn't expect the below code to throw an error/warning.
JelteF
force-pushed
the
yl/small-test-improvements
branch
from
47d79de to
ca59815
Compare
wait_untilhelper