Skip to content

fix build warnings for zenoh-plugin-storage-manager #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

fix build warnings for zenoh-plugin-storage-manager #1919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions zenoh/src/net/runtime/adminspace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
use zenoh_buffers::buffer::SplitBuffer;
use zenoh_config::{unwrap_or_default, wrappers::ZenohId, ConfigValidator, WhatAmI};
use zenoh_core::Wait;
#[cfg(all(feature = "plugins", feature = "runtime_plugins"))]
use zenoh_plugin_trait::PluginDiff;
#[cfg(feature = "plugins")]
use zenoh_plugin_trait::{PluginControl, PluginDiff, PluginStatus};
use zenoh_plugin_trait::{PluginControl, PluginStatus};
#[cfg(feature = "plugins")]
use zenoh_protocol::core::key_expr::keyexpr;
use zenoh_protocol::{
Expand All @@ -39,7 +41,7 @@
use zenoh_transport::unicast::TransportUnicast;

use super::{routing::dispatcher::face::Face, Runtime};
#[cfg(feature = "plugins")]
#[cfg(all(feature = "plugins", feature = "runtime_plugins"))]
use crate::api::plugins::PluginsManager;
use crate::{
api::{
Expand Down Expand Up @@ -95,7 +97,7 @@
}

impl AdminSpace {
#[cfg(feature = "plugins")]
#[cfg(all(feature = "plugins", feature = "runtime_plugins"))]
fn start_plugin(
plugin_mgr: &mut PluginsManager,
config: &zenoh_config::PluginLoad,
Expand Down Expand Up @@ -220,7 +222,7 @@
Arc::new(plugins_status),
);

#[cfg(feature = "plugins")]
#[cfg(all(feature = "plugins", feature = "runtime_plugins"))]

Check warning on line 225 in zenoh/src/net/runtime/adminspace.rs

View check run for this annotation

Codecov / codecov/patch

zenoh/src/net/runtime/adminspace.rs#L225 

Added line #L225 was not covered by tests
let mut active_plugins = runtime
.plugins_manager()
.started_plugins_iter()
Expand Down
Loading