Skip to content

[Security Solution][Alert/Event Flyout] Add pinning and settings to table tab #218686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

[Security Solution][Alert/Event Flyout] Add pinning and settings to table tab #218686

merged 3 commits into from
Apr 23, 2025

Conversation

christineweng
Copy link
Contributor

@christineweng christineweng commented Apr 18, 2025 •
edited by kibanamachine
Loading

Summary

This PR added enhancements to the table tab:

  • User can now pin fields
  • Highlighted fields have a highlighted background
  • Added settings to:
    • Filter table to only show highlighted fields
    • Hide empty values
    • Hide alert fields (kibana.alert.* and signal.*)

Checklist

@christineweng christineweng added release_note:enhancement Team:Threat Hunting:Investigations Security Solution Investigations Team backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Apr 18, 2025
@christineweng christineweng self-assigned this Apr 18, 2025
@christineweng christineweng requested a review from a team as a code owner April 18, 2025 21:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

michaelolo24
michaelolo24 reviewed Apr 21, 2025
View reviewed changes
...y/plugins/security_solution/public/flyout/document_details/right/utils/table_tab_columns.tsx
iconType={isPinned ? 'pinFilled' : 'pin'}
color="text"
iconSize="m"
onClick={() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useCallback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelolo24 useCallback is not allowed within render.. the columns are memoized in the table tab, that should give us some coverage?

michaelolo24
michaelolo24 approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💪🏾 ! Pulled it down and tested and it works great, just had some nits around memoization.

This was referenced Apr 22, 2025
Closed
Closed
PhilippeOberti
PhilippeOberti approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new functionality is really cool! Great job on the code and adding so many tests. Desk tested and code LGTM!
Awesome job @christineweng!!

@christineweng christineweng enabled auto-merge (squash) April 23, 2025 18:43
@christineweng christineweng changed the title [Security Sulution][Alert/Event Flyout] Add pinning and settings to table tab [Security Solution][Alert/Event Flyout] Add pinning and settings to table tab Apr 23, 2025
@christineweng christineweng merged commit f15c96d into elastic:main Apr 23, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/14627340706

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 7285 7288 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.0MB 9.0MB +4.2KB
Unknown metric groups

References to deprecated APIs

id before after diff
securitySolution 361 362 +1

History

cc @christineweng

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 23, 2025
@christineweng
[Security Solution][Alert/Event Flyout] Add pinning and settings to t…
fa4b5d3 
…able tab (elastic#218686)

## Summary

This PR added enhancements to the table tab:
- User can now pin fields
- Highlighted fields have a highlighted background
- Added settings to:
   -  Filter table to only show highlighted fields
   - Hide empty values
   - Hide alert fields (`kibana.alert.*` and `signal.*`)

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit f15c96d)
@kibanamachine kibanamachine mentioned this pull request Apr 23, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 23, 2025
@kibanamachine @christineweng
[8.19] [Security Solution][Alert/Event Flyout] Add pinning and settin…
d53b62f 
…gs to table tab (#218686) (#219018)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Security Solution][Alert/Event Flyout] Add pinning and settings to
table tab (#218686)](#218686)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-23T20:20:34Z","message":"[Security
Solution][Alert/Event Flyout] Add pinning and settings to table tab
(#218686)\n\n## Summary\n\nThis PR added enhancements to the table
tab:\n- User can now pin fields\n- Highlighted fields have a highlighted
background\n- Added settings to:\n - Filter table to only show
highlighted fields\n - Hide empty values\n - Hide alert fields
(`kibana.alert.*` and `signal.*`)\n\n### Checklist\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f15c96d6e811c7a1c1b206c1a0b98c24187ddecf","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Threat
Hunting:Investigations","backport:version","v9.1.0","v8.19.0"],"title":"[Security
Solution][Alert/Event Flyout] Add pinning and settings to table
tab","number":218686,"url":"https://github.com/elastic/kibana/pull/218686","mergeCommit":{"message":"[Security
Solution][Alert/Event Flyout] Add pinning and settings to table tab
(#218686)\n\n## Summary\n\nThis PR added enhancements to the table
tab:\n- User can now pin fields\n- Highlighted fields have a highlighted
background\n- Added settings to:\n - Filter table to only show
highlighted fields\n - Hide empty values\n - Hide alert fields
(`kibana.alert.*` and `signal.*`)\n\n### Checklist\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f15c96d6e811c7a1c1b206c1a0b98c24187ddecf"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218686","number":218686,"mergeCommit":{"message":"[Security
Solution][Alert/Event Flyout] Add pinning and settings to table tab
(#218686)\n\n## Summary\n\nThis PR added enhancements to the table
tab:\n- User can now pin fields\n- Highlighted fields have a highlighted
background\n- Added settings to:\n - Filter table to only show
highlighted fields\n - Hide empty values\n - Hide alert fields
(`kibana.alert.*` and `signal.*`)\n\n### Checklist\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f15c96d6e811c7a1c1b206c1a0b98c24187ddecf"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: christineweng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees

@christineweng christineweng

Labels
backport:version Backport to applied version labels release_note:enhancement Team:Threat Hunting:Investigations Security Solution Investigations Team v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christineweng @elasticmachine @kibanamachine @michaelolo24 @PhilippeOberti