Skip to content

Fix crash on use of EXPORT_NAME with EXPORT_ES6 #24150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix crash on use of EXPORT_NAME with EXPORT_ES6 #24150

wants to merge 1 commit into from

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Apr 18, 2025

Followup to #24138 which introduced the issue.

@sbc100 sbc100 requested a review from kripken April 18, 2025 22:53
@sbc100 sbc100 mentioned this pull request Apr 18, 2025
Merged
kripken
kripken approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm depending on whether you decide to land the reversion.

@kripken
Copy link
Member

kripken commented Apr 18, 2025

I confirmed this gets us past that error on Binaryen.

@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 18, 2025

I confirmed this gets us past that error on Binaryen.

Only the first build error sadly. It fails when it tries to run tests.

@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 21, 2025

Closing this the original change was reverted

@sbc100 sbc100 closed this Apr 21, 2025
@sbc100 sbc100 deleted the export_name branch April 21, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken