Finalize EIP-7702 implementation #2206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some precompiles passing - Add chainId check - fix error msg typo - Put back process_authorizations, use correct ecrecover - Old Call tests passing - Tests for extcodesize, extcodehash, and extcodecopy passing - StaticCall tests down to 10 failing, some cleanup
fselmo
force-pushed
the
eip7702-fixes
branch
4 times, most recently
from
0e87f4d to
9a35d57
Compare
- (DRY) Refactor ``BaseCall`` logic to accommodate some smaller changes to call opcodes so we don't have to re-write a bunch of code for Prague, only overwrite certain methods. - Keep static call logic unchanged. - Track message refunds separately. Even if computation fails, apply message refunds. - Fix some logic to match EIP. Along the way: - Logic for ``secp256k1n/2`` seems to have been wrong in py-evm. Fixed that check and added it to the auth validation.
- Do not pull data floor diff from refunds, nor attempt to use it from the computation gas itself. This should be calculated after refunds and separate from the computation gas. - Add an extra ``data_floor_gas`` property to the computation that is calculated by the transaction executor. This value can be used to calculate the total gas used by the transaction at any point in the processing of the computation. This is useful when issueing refunds and when making the transaction receipt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
How was it fixed?
v4.2.0Todo:
Cute Animal Picture