Skip to content

fix: update teams in readme #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update teams in readme #61

wants to merge 1 commit into from

Conversation

wesleytodd
Copy link
Member

I updated the teams here to do the following:

  1. Updated the team membership to reflect the lists in the readme (removed @ruddermann, but we will always welcome you back if you want 😄)
  2. @expressjs/security-wg-captains now exists and has maintain permissions on this repo and the triage repo
  3. @expressjs/security-wg is now the parent for both @expressjs/security-wg-captains and @expressjs/security-triage

Added the team tags to the readme to aid in folks knowing which one to use for what.

@ctcpip
Copy link
Member

ctcpip commented Apr 17, 2025

nit: typically working groups have 'chairs'

Copy link
Member

@ctcpip ctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but would prefer if we used the word 'chairs' for WG leads

@wesleytodd
Copy link
Member Author

nit: typically working groups have 'chairs'

Valid, but since we have a specific role and defined capabilities for that role that match to what we need, I used Captain. This was more of a pragmatic thing.

@wesleytodd
Copy link
Member Author

@ctcpip
Copy link
Member

ctcpip commented Apr 17, 2025

actually I think that's even more reason to not overload the term! not dying on this hill though 😊

@wesleytodd
Copy link
Member Author

Hm, I am not overloading it. It is literally exactly what is documented there. These people get membership on the team which has maintain and should have the same exact process for nominations. That is intentional IMO.

@ctcpip
Copy link
Member

ctcpip commented Apr 23, 2025

should have the same exact process for nominations

they're not currently the same, nor should they be, but that's also a separate issue 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants