Skip to content

Fix clear all bug when promise has neither a pending nor a success/error #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Fix clear all bug when promise has neither a pending nor a success/error #1112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/toast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ function handlePromise<TData = unknown, TError = unknown, TPending = unknown>(
// Remove the toast if the input has not been provided. This prevents the toast from hanging
// in the pending state if a success/error toast has not been provided.
if (input == null) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of writing double if, you can write in this way with single if -

if (!input && id) {
  toast.dismiss(id);
  return;
}

or

if (input == null && id) {
  toast.dismiss(id);
  return;
}

toast.dismiss(id);
if (id) toast.dismiss(id);
return;
}

Expand Down