-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(cast): Add state overrides flags to cast call #10255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@grandizzy could you please review this PR? |
hey @tushar994 , thanks for PR, will check asap. For checking fmt you should use the nightly as in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly style nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, left some more comments.
…get_or_insert_default. remove clones().
thanks @tushar994 I fixed clippy and fmt and made some nits to simplify code a little like using |
lgtm, waiting for other reviews from team as I've been adding code to it. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okay, we can't really make this simpler because these are just a lot of settings
Motivation
Fixes #10189
I need help with figuring out how to test this functionality.
Solution
adds the relevant override flags
--override-balance "0xAAAA:1234,0xBBBB:5678"
--override-nonce "0xAAAA:5,0xBBBB:10"
--override-code "0xAAAA:0xCODEBYTES"
--override-state "0xAAAA:0xSLOT:1234,0xBBBB:0xSLOT:5678"
--override-state-diff "0xAAAA:0xSLOT:1234,0xBBBB:0xSLOT:5678"
PR Checklist