Skip to content

rpc : add command line option for number of threads for the CPU backend #13060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

rgerganov
Copy link
Collaborator

closes #13051

@rgerganov rgerganov force-pushed the rpc-threads branch 2 times, most recently from 9f3829b to 65de9f5 Compare April 22, 2025 09:33
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the builds, define NOMINMAX before including windows.h:

diff --git a/examples/rpc/rpc-server.cpp b/examples/rpc/rpc-server.cpp
index 5f42e019..0277e25c 100644
--- a/examples/rpc/rpc-server.cpp
+++ b/examples/rpc/rpc-server.cpp
@@ -22,6 +22,7 @@
 
 #include "ggml-rpc.h"
 #ifdef _WIN32
+#  define NOMINMAX
 #  define DIRECTORY_SEPARATOR '\\'
 #  include <locale>
 #  include <windows.h>

@rgerganov rgerganov merged commit 2cca6c0 into ggml-org:master Apr 23, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc. bug: CPU Usage low in rpc-server mode
2 participants