Update GDScript $ node reference tokenization #845
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In the current TextMate grammar for GDScript, the $ symbol used for node references (e.g., $Label) is incorrectly tokenized as keyword.control.flow.gdscript. This causes the symbol to be highlighted with the same color as flow control keywords like if and while, which is semantically incorrect.
Changes
This PR changes the tokenization of the $ node reference symbol from keyword.control.flow.gdscript to constant.character.escape.gdscript in all three relevant patterns:
Benefits
Testing
I've verified these changes with multiple color themes to ensure the highlighting is now consistent and appropriate for this language feature.