Skip to content

Debugger Tool Improvements #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Debugger Tool Improvements #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8368648
Format and fix linter problems
DaelonSuzuka Mar 23, 2025
03ab76a
Fix linter problems
DaelonSuzuka Mar 23, 2025
115269f
Add missing icons to activity bar views
DaelonSuzuka Mar 23, 2025
e1b8cf0
Fixed tree view IDs not being unique
DaelonSuzuka Mar 23, 2025
61c1cc2
Improve EventEmitter usage
DaelonSuzuka Mar 23, 2025
442fad7
Refactor debugger view providers
DaelonSuzuka Mar 23, 2025
95debb8
Remove forEach() loop
DaelonSuzuka Mar 23, 2025
fd8bce4
Don't log two copies of the message body
DaelonSuzuka Mar 23, 2025
8b79565
Automatically request the scene tree every time we enter debug
DaelonSuzuka Mar 23, 2025
5faba45
Fix linter problems
DaelonSuzuka Mar 23, 2025
13a605e
Minor cleanup
DaelonSuzuka Mar 23, 2025
543072e
Change the VariablesManager to have the same lifetime as the DebugSes…
DaelonSuzuka Mar 23, 2025
836779b
Add biome as recommended extension
DaelonSuzuka Mar 23, 2025
dffa701
Add inspector reference to debug session
DaelonSuzuka Mar 23, 2025
5028248
Clear debugging tools when creating new debug session
DaelonSuzuka Mar 23, 2025
f096367
Reset message + description when clear()ing a tree view
DaelonSuzuka Mar 23, 2025
3abc9a8
Add tools dir to biome config
DaelonSuzuka Mar 23, 2025
67dc6c2
Don't discard the thisArg
DaelonSuzuka Apr 20, 2025
76a23d0
Add missing semicolons
DaelonSuzuka Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"recommendations": [
"ms-vscode.extension-test-runner"
"ms-vscode.extension-test-runner",
"biomejs.biome"
]
}
5 changes: 3 additions & 2 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "https://biomejs.dev/schemas/1.9.3/schema.json",
"vcs": {
"defaultBranch": "master"
},
Expand All @@ -9,10 +10,10 @@
"indentWidth": 4,
"lineWidth": 120,
"lineEnding": "lf",
"include": ["src/**/*.ts"]
"include": ["src/**/*.ts", "tools/**/*.ts"]
},
"files": {
"include": ["src/**/*.ts"],
"include": ["src/**/*.ts", "tools/**/*.ts"],
"ignore": ["node_modules"]
},
"linter": {
Expand Down
57 changes: 30 additions & 27 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,32 +642,35 @@
"views": {
"debug": [
{
"id": "activeSceneTree",
"name": "Active Scene Tree"
"id": "godotTools.activeSceneTree",
"name": "Active Scene Tree",
"icon": "resources/godot_icon.svg"
},
{
"id": "inspectNode",
"name": "Inspector"
"id": "godotTools.nodeInspector",
"name": "Inspector",
"icon": "resources/godot_icon.svg"
}
],
"godotTools": [
{
"id": "scenePreview",
"name": "Scene Preview"
"id": "godotTools.scenePreview",
"name": "Scene Preview",
"icon": "resources/godot_icon.svg"
}
]
},
"viewsWelcome": [
{
"view": "activeSceneTree",
"view": "godotTools.activeSceneTree",
"contents": "Scene Tree data has not been requested"
},
{
"view": "inspectNode",
"view": "godotTools.nodeInspector",
"contents": "Node has not been inspected"
},
{
"view": "scenePreview",
"view": "godotTools.scenePreview",
"contents": "Open a Scene to see a preview of its structure"
}
],
Expand Down Expand Up @@ -721,92 +724,92 @@
"view/title": [
{
"command": "godotTools.debugger.refreshSceneTree",
"when": "view == activeSceneTree",
"when": "view == godotTools.activeSceneTree",
"group": "navigation"
},
{
"command": "godotTools.debugger.refreshInspector",
"when": "view == inspectNode",
"when": "view == godotTools.nodeInspector",
"group": "navigation"
},
{
"command": "godotTools.scenePreview.lock",
"when": "view == scenePreview && !godotTools.context.scenePreview.locked",
"when": "view == godotTools.scenePreview && !godotTools.context.scenePreview.locked",
"group": "navigation@1"
},
{
"command": "godotTools.scenePreview.unlock",
"when": "view == scenePreview && godotTools.context.scenePreview.locked",
"when": "view == godotTools.scenePreview && godotTools.context.scenePreview.locked",
"group": "navigation@1"
},
{
"command": "godotTools.scenePreview.refresh",
"when": "view == scenePreview",
"when": "view == godotTools.scenePreview",
"group": "navigation@2"
},
{
"command": "godotTools.scenePreview.openMainScript",
"when": "view == scenePreview",
"when": "view == godotTools.scenePreview",
"group": "navigation@3"
},
{
"command": "godotTools.scenePreview.openCurrentScene",
"when": "view == scenePreview",
"when": "view == godotTools.scenePreview",
"group": "navigation@4"
}
],
"view/item/context": [
{
"command": "godotTools.debugger.inspectNode",
"when": "view == activeSceneTree",
"when": "view == godotTools.activeSceneTree",
"group": "inline"
},
{
"command": "godotTools.debugger.inspectNode",
"when": "view == inspectNode && viewItem == remote_object",
"when": "view == godotTools.nodeInspector && viewItem == remote_object",
"group": "inline"
},
{
"command": "godotTools.debugger.editValue",
"when": "view == inspectNode && viewItem == editable_value",
"when": "view == godotTools.nodeInspector && viewItem == editable_value",
"group": "inline"
},
{
"command": "godotTools.scenePreview.goToDefinition",
"when": "view == scenePreview",
"when": "view == godotTools.scenePreview",
"group": "1@1"
},
{
"command": "godotTools.scenePreview.openDocumentation",
"when": "view == scenePreview",
"when": "view == godotTools.scenePreview",
"group": "1@1"
},
{
"command": "godotTools.scenePreview.copyNodePath",
"when": "view == scenePreview"
"when": "view == godotTools.scenePreview"
},
{
"command": "godotTools.scenePreview.copyResourcePath",
"when": "view == scenePreview && viewItem =~ /hasResourcePath/"
"when": "view == godotTools.scenePreview && viewItem =~ /hasResourcePath/"
},
{
"command": "godotTools.scenePreview.openScene",
"when": "view == scenePreview && viewItem =~ /openable/",
"when": "view == godotTools.scenePreview && viewItem =~ /openable/",
"group": "1@2"
},
{
"command": "godotTools.scenePreview.openScript",
"when": "view == scenePreview && viewItem =~ /hasScript/",
"when": "view == godotTools.scenePreview && viewItem =~ /hasScript/",
"group": "1@2"
},
{
"command": "godotTools.scenePreview.openScene",
"when": "view == scenePreview && viewItem =~ /openable/",
"when": "view == godotTools.scenePreview && viewItem =~ /openable/",
"group": "inline"
},
{
"command": "godotTools.scenePreview.openScript",
"when": "view == scenePreview && viewItem =~ /hasScript/",
"when": "view == godotTools.scenePreview && viewItem =~ /hasScript/",
"group": "inline"
}
],
Expand Down
Loading