[Deployment revisited][Staging][WIP] Fix create config #4724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorguidi
changed the title
vitorguidi
force-pushed
the
chore/fix-create-config
branch
from
2e3f96c to
d970379
Compare
It implements structured logs for task context. It adds the following labels for logs on task context: - Task Id (the UUID one) - Task name - Stage (preprocess, main, postprocess) --------- Signed-off-by: Javan Lacerda <[email protected]>
It moves the `release` and `docker_image` default labels to into the json formatter. before it, this labels were omitted. Signed-off-by: Javan Lacerda <[email protected]>
It creates the structured log for progression tasks, defines de behavior to extract the information from the test case, and add this context behavior for progression preprocess, main and postprocess. --------- Signed-off-by: Javan Lacerda <[email protected]>
…task_id (#4744) It adds `task argument` and `task job name` as properties of task structured log. It also removes the deprecated `task_id` that follows a csv pattern. Signed-off-by: Javan Lacerda <[email protected]>
…4748) Latest changes to add the fuzz target to the testcase-based structured logs was failing when retrieving the fuzz target as a key ID: [error](https://pantheon.corp.google.com/errors/detail/CNuqgM-PtKvgaA;locations=global;time=P30D?project=google.com:clusterfuzz&utm_source=error-reporting-notification&utm_medium=email&utm_content=new-error&e=-13802955&mods=logs_tg_prod&inv=1&invt=Abtmmg). This PR attempts to fix it by using the "binary" field from the FuzzTarget entity, which is also used in the ClusterFuzz frontend to represent the fuzz target.
It adds a catch for exceptions that are raised during the contexts, and log it to have this log with the structured logs. --------- Signed-off-by: Javan Lacerda <[email protected]>
Adding structured logs to regression task using the testcase-based context. For regression postprocess, it was necessary to add code to retrieve the testcase early on, in order to pass it to the context manager. (Also, fixing some style in the logs code).
…ny to DB (#4757) After adding structured logs to testcase-based tasks (#4736), a new error group started showing up due to insufficient permissions/no current context for accessing datastore. This is probably due to querying for the testcase's fuzz target during `utask_main` execution in logs. This tries to solve it by adding the fuzz target as an argument for the logs context, since we can retrieve it from the datastore entity in trusted part and from the protobuf during the untrusted part of the task. --------- Signed-off-by: Vinicius da Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create config has gotten stale over time. A few encountered issues:
This PR addresses the above issues
Part of #4728