Adds module mapping of includes for Rust code generation #8563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c++
codegen
csmulhern
force-pushed
the
master
branch
2 times, most recently
from
b9695b0 to
e4bfc82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
--module-mappingflag to flatc that can be used to map included file paths to existing modules that have been compiled for those schemas.This is useful for module based languages (e.g. Swift, Rust), as it allows schemas to be compiled into different units (modules) while still referencing one another. In order for the flatbuffer compiler to know the module associated with a particular schema, a mapping is passed in the command line invocation, using the format
--module-mapping PATH=MODULE. Multiple uses of this flag are accumulated, so that multiple schemas can be simultaneously mapped.Initial support has been added in the Rust code generator.
For more background on what motivated this change, see the discussion in #8273.
Fixes #8273.