-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Improve compile_native_go_fuzzer
command to detect fuzzer functions more precisely.
#13220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdamKorcz PTAL since you added this script, fairly trivial change
/gcbrun trial_build.py go-attestation go-coredns go-dns go-ethereum go-json-iterator go-redis go-sftp go-snappy go-sqlite3 golang golang-protobuf gonids grpc-go syzkaller kubernetes --sanitizer coverage --fuzzing-engine libfuzzer |
d68bb00
to
51b8c4f
Compare
@sudiptob2 can you let me know when you have finished making commits? I need to launch an experiment and would prefer to do this once you believe this is ready |
@DavidKorczynski hey got it, its ready. I just rebased it. I wont rebase it anymore unless you are done with the experiment. |
/gcbrun trial_build.py go-attestation go-coredns go-dns go-ethereum go-json-iterator go-redis go-sftp go-snappy go-sqlite3 golang golang-protobuf gonids grpc-go syzkaller kubernetes --sanitizer coverage --fuzzing-engine libfuzzer |
@DavidKorczynski Do we think this is ready? |
yes |
The
grep
command used incompile_native_go_fuzzer
does not work correctly when fuzzers have similar names. Consider the following example:We have two fuzzers:
FuzzGatewayAPIToXDS
FuzzGatewayAPIToXDSWithGatewayClass
Compile command:
Since the target string appears in both fuzzer names, the grep command returns 2 matches instead of 1.
This PR adds an additional
"("
to more precisely identify the fuzzer name.Also, added
set -x
for better debugging.