Skip to content

fix(background): avoid duplicate polyfill script warning #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Apr 25, 2025

Context

On browser start, there was a warning that the polyfill script was already registered.
Also, this warning was incorrectly included in the "Content script execution world MAIN not supported by your browser" warning.

image

Changes proposed in this pull request

  • Set persistAcrossSessions: false to prevent error in first place and for consistency with other content scripts.
  • Silence duplicate script error (different browsers may have different error message)

@sidvishnoi sidvishnoi requested a review from DarianM April 25, 2025 09:01
@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Apr 25, 2025
Copy link
Contributor

Extension builds preview

Name Link
Latest commit 5e22aef
Latest job logs Run #14660926641
Chrome (989.6KB)Download
Firefox (989.62KB)Download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant