Skip to content

fix(bg/storage): store user provided wallet URL as well #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(bg/storage): store user provided wallet URL as well #1033

wants to merge 2 commits into from

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Apr 28, 2025 •
edited
Loading

Context

Useful with #1029
Some wallet URLs have redirects, and the resulting resourceServer could be something that corresponds to a different wallet as well.

With this info stored, we can:

  • help distinguish those redirect wallets (MMAON, ilp.dev) from their managing wallets
  • display the wallet address that user entered in UI - like UI showing ilp.dev instead of ilp.interledger.cards address (not done yet)

Changes proposed in this pull request

  • Store walletAddressUrl as walletAddress.url in extension storage.
    • The url property isn't part of standard WalletAddress response, so it's safe to add to storage within this object.

Example: User input $ilp.interledger-test.dev/sid at connectWallet gets stored like this:
image

@sidvishnoi sidvishnoi requested a review from DarianM April 28, 2025 13:40
@github-actions github-actions bot added area: background Improvements or additions to extension background script area: shared Changes to shared libraries and utilities labels Apr 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 28, 2025 •
edited
Loading

Extension builds preview

Name Link
Latest commit 594c08d
Latest job logs Run #14709388997
Chrome (989.58KB)Download
Firefox (989.61KB)Download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianM DarianM Awaiting requested review from DarianM

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: shared Changes to shared libraries and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sidvishnoi