Skip to content

Add core client traits for read-only and read-write IOTA operations #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

itsyaasir
Copy link
Contributor

Description of change

This PR is for adding the client interfaces as we discussed yesterday. This PR won't be merged in as the client traits will be transferred to products-core but I decided to do the leg work so it will be easy to transfer.

After the transfer, I will open an issue for the Identity clients to implements the traits as required.

All comments are welcome.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@itsyaasir itsyaasir self-assigned this Apr 15, 2025
@itsyaasir itsyaasir requested a review from a team as a code owner April 15, 2025 12:29
@itsyaasir itsyaasir marked this pull request as draft April 15, 2025 12:34
@itsyaasir itsyaasir requested a review from UMR1352 April 15, 2025 13:14
@itsyaasir itsyaasir requested review from chrisgitiota and a team April 16, 2025 07:44
@eike-hass eike-hass changed the base branch from feat/identity-rebased-alpha to main April 17, 2025 13:37
@eike-hass eike-hass force-pushed the main branch 2 times, most recently from bb21207 to 42fc734 Compare April 22, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants