Skip to content

Remove suspected unused code #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Remove suspected unused code #478

merged 1 commit into from
Apr 22, 2025

Conversation

krassowski
Copy link
Member

Checking if any tests fail when removing code highlighted in #477

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch krassowski/jupyter_collaboration/remove-dead-code

@krassowski krassowski marked this pull request as ready for review April 19, 2025 18:38
davidbrochart
davidbrochart approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidbrochart davidbrochart merged commit 5a75e2c into jupyterlab:main Apr 22, 2025
29 checks passed
@davidbrochart davidbrochart mentioned this pull request Apr 22, 2025
Closed
@brichet
Copy link
Contributor

brichet commented Apr 22, 2025

The CHAT message type can also be removed, I think

jupyter-collaboration/projects/jupyter-server-ydoc/jupyter_server_ydoc/utils.py

Line 22 in a7af554

CHAT = 125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krassowski @brichet @davidbrochart