bash format added in make format #1329
Conversation
Signed-off-by: Yash Patel <[email protected]>
Signed-off-by: Yash Patel <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hzxuzhonghu waiting for review !! |
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Do you use https://github.com/mvdan/sh? |
|
yes |
|
shfmt package is not available in yum , I think I have to use go |
|
@hzxuzhonghu can u see now |
Signed-off-by: Yash Patel <[email protected]>
| install_tool clang-format | ||
| fi | ||
| function install_shell_format() { | ||
| go install mvdan.cc/sh/v3/cmd/shfmt@latest |
There was a problem hiding this comment.
we should better install a stable version, rather than latest
There was a problem hiding this comment.
getting error if i remove latest tag
no required module provides package mvdan.cc/sh/v3/cmd/shfmt; to add it:
go get mvdan.cc/sh/v3/cmd/shfmt
There was a problem hiding this comment.
docs also recommends to download with latest tag https://github.com/mvdan/sh
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
bash format added in make format
Which issue(s) this PR fixes:
Fixes #1328
Special notes for your reviewer:
Does this PR introduce a user-facing change?: