Skip to content

rfac: initialized enable_monitoring to 1 #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2025
Merged

Conversation

yp969803
Copy link
Contributor

/kind bug

What this PR does / why we need it:
We initialize enable_monitoring with false, which is wrong

Which issue(s) this PR fixes:
Fixes #1333

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Apr 24, 2025
@yp969803
Copy link
Contributor Author

@hzxuzhonghu can u merge it !!

Signed-off-by: Yash Patel <[email protected]>

rfac: included stdbool.h to cgroup_skb.c
@kmesh-bot kmesh-bot added size/M and removed size/S labels Apr 24, 2025
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.89%. Comparing base (a4bc785) to head (a324207).
Report is 9 commits behind head on main.

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc9468...a324207. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yp969803
Copy link
Contributor Author

@hzxuzhonghu can u merge it !!

@yp969803
Copy link
Contributor Author

/retest

@hzxuzhonghu
Copy link
Member

Seems a regression from #1263, which turned this ferature off. This makes me realize we donot have any e2e test on this feat cc @YaoZengzeng @LiZhenCheng9527

@hzxuzhonghu
Copy link
Member

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 43c2a71 into kmesh-net:main Apr 27, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monitoring_enable global variable not setting for cgroup_skb prog
3 participants