Skip to content

✨ (helm/v1-alpha): Update Helm values.yaml with Kustomize manager spec changes when using --force flag #4782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✨ (helm/v1-alpha): Update Helm values.yaml with Kustomize manager spec changes when using --force flag #4782

wants to merge 1 commit into from

Conversation

sarthaksarthak9
Copy link
Member

@sarthaksarthak9 sarthaksarthak9 commented Apr 15, 2025 •
edited
Loading

fixes: #4625

  • Improves YAML number type handling for replicas, terminationGracePeriodSeconds, and other numeric values
  • Ensures proper extraction of resource limits, requests, container args, and termination grace period from manager.yaml
  • Correctly populates values.yaml with the latest configuration from manager.yaml when using the --force flag

Screenshot from 2025-04-14 22-38-12

Screenshot from 2025-04-14 22-39-01

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sarthaksarthak9
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 15, 2025
@sarthaksarthak9 sarthaksarthak9 changed the title 🐛 fix: --force flag does not update values.yaml ✨ fix: --force flag does not update values.yaml Apr 15, 2025
@sarthaksarthak9 sarthaksarthak9 force-pushed the flag branch 3 times, most recently from ecfd3b2 to c43f61f Compare April 15, 2025 07:30
@sarthaksarthak9 sarthaksarthak9 changed the title ✨ fix: --force flag does not update values.yaml ✨ --force flag does not update values.yaml Apr 16, 2025
@sarthaksarthak9 sarthaksarthak9 changed the title ✨ --force flag does not update values.yaml ✨ (helm/v1-alpha): Update Helm values.yaml with Kustomize manager spec changes when using --force flag Apr 16, 2025
@sarthaksarthak9
Copy link
Member Author

@camilamacedo86 could you please help to correct the PR title? I'm not sure why it's failing the test. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(helm/v1-alpha) --force flag does not update values.yaml when kustomize manager spec has changed
3 participants
@sarthaksarthak9 @k8s-ci-robot @camilamacedo86