This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Improve log scrolling. #1018
Closed
Improve log scrolling. #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, we only keep scrolled to the bottom if the user scrolls to the bottom. If the user scrolls up, we maintain their scroll position.
valentinewallace
force-pushed
the
logs-scrolling
branch
from
51a0075 to
cec074f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, we only keep scrolled to the bottom if the user scrolls to the bottom. If the user scrolls up, we maintain their scroll position.
The logs scrolling still isn't perfect but this should be a significant improvement.
Closes #989.