Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When quantizing the (input) activations to the bit-linear layer,
$Quant(x) = Clip(x \times \frac{Q_b}{||x||_\infty}, -Q_b + \epsilon, Q_b - \epsilon$
NaN
s may occur due to division by zero. This is a consequence of the formula in the original paper:In the extreme case where all activations are zero, this will result in abs-max being zero, and thus a division by zero.
To fix this, I made sure to add
1e-10f
to all maxes in the preset kernels. In 99.99% of cases, this will be a minor (or no) change, but in problematic cases, this avoidsNaN
s.