Fix #61429: Fast arithmetic type check for type-parameters upper-bounded by bigint fixed

[CurtisFenner]

Fixes #61429

The maybeTypeOfKind function is a simpler version of full type-checking which is used by arithmetic. Previously it was used to determine whether arithmetic operations such as +, <<, and ~ were acting on number types or bigint types.

Note that these type checks are somewhat complicated by a desire to preserve unsoundness: any * any should be number, rather than the (sound but exceedingly impractical) number | bigint.

Previously, the maybeTypeOfKind function did not return true when an operand has a type T, regardless of the bounds of T. This meant that when maybeTypeOfKind is passed T extends bigint and bigint, it returned false.

This caused expressions like a & b to be assigned the "default" type number instead of bigint.

---

To fix this issue, I updated the checks to instead use maybeTypeOfKindConsideringBaseConstraint. I suspect that some of the other uses of maybeTypeOfKind have similar issues, but if so they seem much more subtle and I wasn't able to construct any suspicious tests for them.

---

I added the bigintSubtypingTypeParameter test which includes a variety of unary and binary operators acting on such T extends bigint values.

---

This is my first PR, so apologies if I'm missing something important.

[CurtisFenner]

@microsoft-github-policy-service agree

[CurtisFenner]

@jakebailey Hi, I'm not sure if you missed the new approach I took. I found a more appropriate maybeTypeOfKindConsideringBaseConstraint and audited all the existing callers of maybeTypeOfKind to see which obviously should be using it. (I also did an extraction of getBinaryArithmeticResultType into a function since it was a large code block in a large chain of alternatives, to be more similar to the getUnaryResultType)

Apologies if you were already aware, I'm sure you have more important tasks to attend to for TypeScript!