Skip to content

fix typo in python code #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix typo in python code #151

wants to merge 1 commit into from

Conversation

bmoussaud
Copy link

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 10, 2025 09:45
Copy link

👋 Thanks for contributing @bmoussaud! We will review the pull request and get back to you soon.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

09-metacognition/code_samples/09-semantic-kernel.ipynb:312

  • The inline style string is missing a closing double quote before the ">", which may cause HTML rendering issues.
html_output += f"<div style='margin:10px; padding:10px; background-color:#f8f8f8; border:1px solid #ddd; border-radius:4px; white-space:pre-wrap; font-size:14px; color:#333;>"

09-metacognition/code_samples/09-semantic-kernel.ipynb:409

  • Similar to the change at line 312, the inline style string here is missing a closing double quote before the ">", which could disrupt the intended HTML layout.
html_output += f"<div style='margin:10px; padding:10px; background-color:#f8f8f8; border:1px solid #ddd; border-radius:4px; white-space:pre-wrap; font-size:14px; color:#333;>"

Copy link
Contributor

@moonbox3 moonbox3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please help me understand where the typo is? It's hard to see given that the execution output is included.

@@ -2,7 +2,7 @@
"cells": [
{
"cell_type": "code",
"execution_count": 1,
"execution_count": 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should commit notebooks that have clear outputs, and thus no execution count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants