Typos and doc tweaks #1181
Open
Typos and doc tweaks #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
approved these changes
Apr 14, 2025
| @@ -41,11 +41,11 @@ the Language Server Protocol Spec defines [a general purpose cancellation protoc | |||
| which StreamJsonRpc supports. Notifications cannot be canceled. | |||
|
|
|||
| A client can cancel a request by canceling a `CancellationToken` supplied when originally invoking the request. | |||
| Be sure to call the `JsonRpc.Invoke*` method and overload that explicitly accepts `CancellationToken` | |||
| Be sure to call the `JsonRpc.Invoke*` method and an overload that explicitly accepts `CancellationToken` | |||
There was a problem hiding this comment.
This probably needed a fix, but maybe not the one you propose. They only call one thing, but and suggested two things.
Suggested change
| Be sure to call the `JsonRpc.Invoke*` method and an overload that explicitly accepts `CancellationToken` | |
| Be sure to call the `JsonRpc.Invoke*` method overload that explicitly accepts `CancellationToken` |
There was a problem hiding this comment.
How about:
Suggested change
| Be sure to call the `JsonRpc.Invoke*` method and an overload that explicitly accepts `CancellationToken` | |
| Be sure to call an overload of a `JsonRpc.Invoke*` method that explicitly accepts `CancellationToken` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor change suggestions seen while reading this doc.