Add live timer to activities in the activity log #1119
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcegroups into nat/convertActivityLogV2
|
Where will progress messages go now? |
Oops, I put that info in the other PR but didn't add it here. Updated, let me know if you have any other questions! |
|
Update: Waiting to merge this and the associated utils work until after next RG release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on microsoft/vscode-azuretools#1967:
Example images:
We had discussed adding a live activity timer and hiding progress reports from the activity log description since we were migrating to showing activity children anyway.
(Note: Progress reports would still be used in commands leveraging the Azure Wizard without registering an activity, see below.)
https://github.com/microsoft/vscode-azuretools/blob/713123e274ceb0ae434395bbe80048e6780cddfa/utils/src/wizard/AzureWizard.ts#L293