Skip to content

feat: allow editing of submission by the user #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented Apr 21, 2025

This fixes #1110 and #1656 and is a follow-up on #1690 by @tpokorra

@Chartman123 Chartman123 changed the title patch for AllowEdit for Forms5 feat: allow editing of submission by the user Apr 21, 2025
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from 593625b to a1819bf Compare April 21, 2025 21:03
@Chartman123 Chartman123 added enhancement New feature or request php PHP related ticket javascript Javascript related ticket 2. developing Work in progress feature: 📊 responses & statistics feature: 📝 submitting responses labels Apr 21, 2025
@Chartman123 Chartman123 self-assigned this Apr 21, 2025
@Chartman123 Chartman123 added this to the 5.2 milestone Apr 21, 2025
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from a1819bf to a77a31e Compare April 21, 2025 21:06
@Chartman123 Chartman123 linked an issue Apr 22, 2025 that may be closed by this pull request
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch 7 times, most recently from 518fa22 to 4e500db Compare April 24, 2025 11:42
tpokorra and others added 2 commits April 24, 2025 16:56
Signed-off-by: Timotheus Pokorra <[email protected]>
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from 54b34fc to c04154b Compare April 24, 2025 14:57
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 24, 2025
@Chartman123 Chartman123 marked this pull request as ready for review April 24, 2025 14:58
Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from ae2dcb9 to 3f68b3a Compare April 24, 2025 16:09
@Chartman123 Chartman123 requested review from AIlkiv, susnux and Koc April 24, 2025 16:09
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch 3 times, most recently from b581319 to cd01c54 Compare April 24, 2025 18:39
Signed-off-by: Christian Hartmann <[email protected]>
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch 2 times, most recently from d2dda2b to 0524520 Compare April 24, 2025 19:26
Signed-off-by: Christian Hartmann <[email protected]>
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from 0524520 to eb0b3e6 Compare April 24, 2025 19:38
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 19.81982% with 89 lines in your changes missing coverage. Please review.

Project coverage is 42.64%. Comparing base (e88ba60) to head (fc475b5).
Report is 15 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2715      +/-   ##
============================================
- Coverage     43.55%   42.64%   -0.92%     
- Complexity      908      940      +32     
============================================
  Files            78       79       +1     
  Lines          3391     3494     +103     
============================================
+ Hits           1477     1490      +13     
- Misses         1914     2004      +90     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from 3e9a9c7 to fc475b5 Compare April 24, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: 📊 responses & statistics feature: 📝 submitting responses javascript Javascript related ticket php PHP related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show all own submitted entries to user Change my submitted form
2 participants